Add omole as an enterprise reviewer. (#4450)

* Add omole as an enterprise reviewer. * updated tests
GoogleChrome · Oct 16, 2024 · 85aa6e2 · 85aa6e2
1 parent 28866b6
commit 85aa6e2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/internals/approval_defs.py b/internals/approval_defs.py
@@ -44,6 +44,7 @@
     'mhoste@google.com',
     'angelaweber@google.com',
     'davidayad@google.com',
+    'omole@google.com',
 ]
 DEBUGGABILITY_APPROVERS = IN_NDB
 TESTING_APPROVERS = [

diff --git a/internals/reminders_test.py b/internals/reminders_test.py
@@ -400,11 +400,12 @@ def test_get_template_data__one_due_unassigned(self, mock_remaining_days):
     with test_app.app_context():
       actual = self.handler.get_template_data()
 
-    expected_message = (f'3 email(s) sent or logged.\n'
+    expected_message = (f'4 email(s) sent or logged.\n'
                         'Recipients:\n'
                         'angelaweber@google.com\n'
                         'davidayad@google.com\n'
-                        'mhoste@google.com')
+                        'mhoste@google.com\n'
+                        'omole@google.com')
     expected = {'message': expected_message}
     self.assertEqual(actual, expected)
 
@@ -437,11 +438,12 @@ def test_get_template_data__one_overdue_unassigned(self, mock_remaining_days):
     with test_app.app_context():
       actual = self.handler.get_template_data()
 
-    expected_message = (f'3 email(s) sent or logged.\n'
+    expected_message = (f'4 email(s) sent or logged.\n'
                         'Recipients:\n'
                         'angelaweber@google.com\n'
                         'davidayad@google.com\n'
-                        'mhoste@google.com')
+                        'mhoste@google.com\n'
+                        'omole@google.com')
     expected = {'message': expected_message}
     self.assertEqual(actual, expected)
 
@@ -457,12 +459,13 @@ def test_get_template_data__one_overdue_assigned(self, mock_remaining_days):
     with test_app.app_context():
       actual = self.handler.get_template_data()
 
-    expected_message = (f'4 email(s) sent or logged.\n'
+    expected_message = (f'5 email(s) sent or logged.\n'
                         'Recipients:\n'
                         'a_assignee@example.com\n'
                         'angelaweber@google.com\n'
                         'davidayad@google.com\n'
-                        'mhoste@google.com')
+                        'mhoste@google.com\n'
+                        'omole@google.com')
     expected = {'message': expected_message}
     self.assertEqual(actual, expected)