-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Draft: web.dev/url [DO NOT PUBLISH BEFORE TECHNICAL REVIEW] #9613
Conversation
✅ Deploy Preview for web-dev-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, mostly take it or leave it. Otherwise lgtm!
### Anchor {: #anchor} | ||
|
||
See | ||
[hash](#hash). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest scrapping this, and instead labeling the below glossary item "Hash or anchor." Since this is a casual glossary (listing items in an article rather than the capital-G Glossary), they don't need to be separated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea — thanks.
### Query string | ||
|
||
See [search](#search). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider doing the same as suggested for anchor / hash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise — I've done as you suggested.
Co-authored-by: Alexandra White <alexandrawhite@google.com>
Co-authored-by: Alexandra White <alexandrawhite@google.com>
Co-authored-by: Alexandra White <alexandrawhite@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started leaving comments, but now I feel like I might not understand the purpose of this article.
{% Aside %} | ||
The named parts of a URL may coincide, but that doesn't mean they're equivalent! | ||
|
||
The [FQDN](#fqdn), [eTLD+1](#etld1), [hostname](#hostname) and [registrable domain](#registrable-domain) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's terribly useful to introduce "fully-qualified domain name" as the first concept you point to here. It doesn't appear in the URL spec, and I'm fairly sure it's equivalent to host
in URL's parlance? AFAIK, the distinction would only come up in the context of DNS, where computername
and computername.corp.internal.network
might resolve to the same address. That complexity doesn't seem worth raising here (except possibly in a note suggesting that host
and fqdn
are the same on the open web, and only might differ on local networks).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, I think it's best for us to merge "eTLD+1" and "registrable domain" into the latter, following URL. Again, it might be reasonable to note that lots of people will call it "eTLD+1", but we should encourage alignment on one term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mike (belatedly!) I've actually removed this bit — I think the aside was more confusing than useful anyway.
The named parts of a URL may coincide, but that doesn't mean they're equivalent! | ||
|
||
The [FQDN](#fqdn), [eTLD+1](#etld1), [hostname](#hostname) and [registrable domain](#registrable-domain) | ||
may be the same for some URLs, but each term has a different meaning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, I don't think each term does have a different meaning. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right — now removed (as per previous comment).
may be the same for some URLs, but each term has a different meaning. | ||
{% endAside %} | ||
|
||
Edit the URL in the Glitch below to see the part names. (You can also open this in a separate tab at [url-parts.glitch.me](https://url-parts.glitch.me).) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above, I'd like to see this Glitch align with URL and use "registrable domain".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the Glitch to use "registrable domain" (with eTLD+1 in brackets, in case people see that term).
@samdutton - The Widget is updated and the code for your demo is provisionally checked in under https://github.com/GoogleChrome/web.dev/tree/main/src/site/content/en/demos/url-parts and https://github.com/GoogleChrome/web.dev/tree/main/src/site/content/en/third_party. Feel free to edit demo files and include the widget with |
Thanks so much, Ewa!
…On Mon, 27 Feb 2023 at 14:46, Ewa ***@***.***> wrote:
@samdutton <https://github.com/samdutton> - The Widget is updated and the
code for your demo is provisionally checked in under
https://github.com/GoogleChrome/web.dev/tree/main/src/site/content/en/demos/url-parts
and
https://github.com/GoogleChrome/web.dev/tree/main/src/site/content/en/third_party.
Feel free to edit demo files and include the widget with {% Widget
'demos/url-parts' %} if you find it suitable.
—
Reply to this email directly, view it on GitHub
<#9613 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABSDKTWDPMAKB4Q5JDQ7JDWZS445ANCNFSM6AAAAAAU7YUYFY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@devnook On hold, pending resolution of technical concerns — after I'm back on 29 March. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To prevent this from happening, leave a comment. |
Closing as the site is now migrated. |
An article explaining the names of URL parts.
@heyawhite — as discussed, I've requested you as a reviewer, but feel free to pass this on.
Once this has had tech writer review, I'll get a technical review done.
[DO NOT PUBLISH BEFORE TECHNICAL REVIEW]