Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement three-way appearance #90

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

Haocen
Copy link
Contributor

@Haocen Haocen commented Sep 21, 2024

Close: #46

It seems linter introduce some changes to files I didn't touch, let me know if it is not desired.

Copy link
Member

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

After the merge, I'll replace the Yin Yang symbol with something else. I don't personally mind it, but some people might read something into it.

@tomayac tomayac merged commit cca8eda into GoogleChromeLabs:main Sep 23, 2024
1 of 2 checks passed
@tomayac
Copy link
Member

tomayac commented Sep 23, 2024

Thank you very much, this is now released as v0.16.0. <3

@Haocen
Copy link
Contributor Author

Haocen commented Sep 23, 2024

Looks like there is a build failure, I'm not sure what I need to do.
The yin-yang is the only symbol I can find available from the public domain immediately, I agree it would be better if we can replace it with the half sun half moon symbol that was originally proposed.

@tomayac
Copy link
Member

tomayac commented Sep 23, 2024

I think it's all fine now. v0.16.0 just went out on npm and the demo looks good to me. Thanks again!

@Haocen Haocen deleted the pr-three-way branch September 24, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apart from light and dark, add a system option
2 participants