Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Emscripten runtime failure #349

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Fix Emscripten runtime failure #349

merged 3 commits into from
Nov 2, 2023

Conversation

hoch
Copy link
Member

@hoch hoch commented Nov 2, 2023

Fixes #348.

The latest stable of Emscripten 3.1.47 caused some runtime errors in the WASM SuperSaw example, and this PR fixes the problem. The details can be found here: #348 (comment)

@hoch hoch requested a review from mjwilson-google November 2, 2023 18:12
@mjwilson-google
Copy link
Collaborator

This is a huge diff and the Emscripten install instructions are installing 3.1.47 for me, so it might take a few days for me to work through this.

@hoch
Copy link
Member Author

hoch commented Nov 2, 2023

synth.wasm.js is machine-generated and you do not need to review.

The latest ToT can be installed by:

./emsdk install tot

@mjwilson-google
Copy link
Collaborator

Thank you, I now have 3.1.48-git installed. The make reports that it succeeds, but I don't see an index.html file to serve. Is there another step to convert the index.njk file?

@hoch
Copy link
Member Author

hoch commented Nov 2, 2023

For that, you can follow the top-level instruction:
https://github.com/GoogleChromeLabs/web-audio-samples/#how-to-make-changes-and-depoly

In short, do this in the terminal and run the example:

npm run start

I guess this PR is a good excuse to learn how to build/deploy the web-audio-samples project! :)

@mjwilson-google
Copy link
Collaborator

Thank you, I was able to reproduce the bug and verify the fix. LGTM!

@hoch hoch merged commit b3b0851 into main Nov 2, 2023
2 checks passed
@hoch hoch deleted the 348-empscripten-failure branch May 14, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The latest Emscripten is broken for WASM examples
2 participants