Skip to content

Commit

Permalink
Update the Jupyter notebook image version (#886)
Browse files Browse the repository at this point in the history
* Update the Jupyter notebook image version
  • Loading branch information
gongmax authored Nov 25, 2024
1 parent 3a39329 commit 63747e6
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 4 deletions.
2 changes: 1 addition & 1 deletion applications/rag/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ module "jupyterhub" {
workload_identity_service_account = local.jupyter_service_account

notebook_image = "us-central1-docker.pkg.dev/ai-on-gke/rag-on-gke/jupyter-notebook-image"
notebook_image_tag = "v1.1-rag"
notebook_image_tag = "sample-public-image-v1.1-rag"

db_secret_name = module.cloudsql.db_secret_name
cloudsql_instance_name = local.cloudsql_instance
Expand Down
12 changes: 12 additions & 0 deletions modules/jupyter/jupyter_image/notebook_image/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
To build a new jupyter notebook image and use it for the RAG QSS:
1. Update the cloudbuild.yaml with the new image tag.

The iamge tag should follow the pattern `sample-public-image-v<VERSION_NUMBER>-rag`.The prefix `sample-public-image-` is needed to so the images will internally be considered as vulnerability remediated and no more bugs will be filed for them.
2. Then in this path, run:

`gcloud config set project ai-on-gke`

`gcloud builds submit --config cloudbuild.yaml .`

This will build and push the new image to the registry `us-central1-docker.pkg.dev/ai-on-gke/rag-on-gke`
3. Update the `notebook_image_tag` in `/applications/rag/main.tf` to the new image tag.
4 changes: 2 additions & 2 deletions modules/jupyter/jupyter_image/notebook_image/cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ steps:
- name: 'gcr.io/cloud-builders/docker'
args: [ 'pull', 'docker.io/jupyter/tensorflow-notebook:python-3.10' ]
- name: 'gcr.io/cloud-builders/docker'
args: [ 'build', '-t', '<Artiact registry repo>/<image name>', '.' ]
args: [ 'build', '-t', 'us-central1-docker.pkg.dev/ai-on-gke/rag-on-gke/jupyter-notebook-image:<NEW_IMAGE_TAG>', '.' ]
images:
- '<Artiact registry repo>/<image name>'
- 'us-central1-docker.pkg.dev/ai-on-gke/rag-on-gke/jupyter-notebook-image:<NEW_IMAGE_TAG>'
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
langchain==0.3.7
langchain==0.3.7
ray==2.9.3
datasets==2.18.0
sentence-transformers==2.5.1
Expand Down

0 comments on commit 63747e6

Please sign in to comment.