Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licensing and change contribution md location #105

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Add licensing and change contribution md location #105

merged 1 commit into from
Nov 2, 2023

Conversation

chiayi
Copy link
Collaborator

@chiayi chiayi commented Nov 1, 2023

This is required as part of launch. Having a launch is required to setup a public project.

@tallclair
Copy link
Collaborator

This should have a pre-submit check if we want to maintain the requirement. You can look into reusing the Kubernetes script if there isn't an off the shelf github version: https://github.com/kubernetes/kubernetes/tree/master/hack/boilerplate

@imreddy13 imreddy13 closed this Nov 2, 2023
@chiayi chiayi reopened this Nov 2, 2023
Copy link
Collaborator

@imreddy13 imreddy13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 that this needs a presubmit so we don't ever have to do this again, but I think that can be a separate task to unblock the turbo

@chiayi chiayi merged commit 88bb2c8 into main Nov 2, 2023
6 checks passed
leroyjb pushed a commit to leroyjb/ai-on-gke that referenced this pull request Jan 24, 2025
…evelop

Add licensing and change contribution md location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants