Add GCS as a storage solution #130
Conversation
chiayi
force-pushed
the
develop
branch
5 times, most recently
from
2090fd4 to
af82308
Compare
| extraAnnotations: | ||
| gke-gcsfuse/volumes: "true" | ||
| gke-gcsfuse/cpu-limit: 500m | ||
| gke-gcsfuse/memory-limit: 100Mi |
There was a problem hiding this comment.
I would suggest increasing this memory limit to at least 250Mi.
| @@ -46,6 +46,16 @@ resource "google_container_cluster" "ml_cluster" { | |||
| workload_pool = "${var.project_id}.svc.id.goog" | |||
| } | |||
|
|
|||
| addons_config { | |||
| gcp_filestore_csi_driver_config { | |||
There was a problem hiding this comment.
This should be in the filestore PR?
There was a problem hiding this comment.
Will move it to the filestore PR.
jupyter-on-gke/images/gcs_bucket.png
Outdated
There was a problem hiding this comment.
This image is used by the storage.md file.
| @@ -23,7 +23,7 @@ | |||
| # Available chart versions: https://jupyterhub.github.io/helm-chart/ | |||
| hub: | |||
| image: | |||
| name: <Repo name here> | |||
| name: us-docker.pkg.dev/ai-on-gke/jupyterhub-authentication-class/jupyter-auth-class | |||
There was a problem hiding this comment.
Can we pull this out to a separate PR and submit it sooner? It's not related to GCS right?
There was a problem hiding this comment.
Created a separate PR: #133
| @@ -78,10 +78,20 @@ singleuser: | |||
| ephemeral-storage: 10Gi | |||
| nodeSelector: | |||
| iam.gke.io/gke-metadata-server-enabled: "true" | |||
| extraEnv: | |||
| JUPYTER_ALLOW_INSECURE_WRITES: "true" | |||
There was a problem hiding this comment.
Maybe add a comment explaining why this is needed/ what error you see without
There was a problem hiding this comment.
Added a comment on top explaining what this variable does, not sure why it doesn't show here.
chiayi
force-pushed
the
develop
branch
3 times, most recently
from
b7a0e3c to
47695c8
Compare
Added choices to jupyterhub storage solutions selection. Currently default and GCSFuse.