remove csv file write #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annapendleton
force-pushed
the
remove-csv
branch
from
9ea2335 to
5774233
Compare
kaushikmitr
approved these changes
Mar 28, 2024
...benchmark/tools/locust-load-inference/locust-docker/locust-tasks/custom_metric_aggregator.py
Show resolved
Hide resolved
kfswain
pushed a commit
that referenced
this pull request
Apr 15, 2024
remove csv file write. custom_messages has bug that causes locust worker restarts
leroyjb
pushed a commit
to leroyjb/ai-on-gke
that referenced
this pull request
Jan 24, 2025
remove csv file write. custom_messages has bug that causes locust worker restarts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
custom_messages has bug that causes locust worker restarts. locustio/locust#2608
We rely on custom messages for our custom metrics csv file periodic writes.
Since we've added in exporting the custom metrics to prometheus, I don't think we need the csv file write. The locust runner includes these metrics in its final report. And metrics are viewable via custom dashboards in cloud monitoring.
Rather than trying to make the heartbeat work, I think we should remove the csv file support and migrate to improving the total report that includes locust and GPU metrics as well.
This change also enables custom metrics for all workloads.