TPU Provisioner: Add support for v6e & cross project reservations #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebinaryone1
approved these changes
Oct 17, 2024
nstogner
force-pushed
the
tpu-provisioner-v6e
branch
from
58eb455 to
bafb427
Compare
thebinaryone1
approved these changes
Dec 4, 2024
nstogner
changed the title
nstogner
commented
Dec 6, 2024
nstogner
force-pushed
the
tpu-provisioner-v6e
branch
from
c9652d8 to
217c493
Compare
|
@nstogner I think we might need to update tpu-provisioner/cloudbuild.yaml: name: 'golang:1.22' -> 1.23? This is the failure in the tests currently: "Error: load packages in root "/workspace/tpu-provisioner": err: exit status 1: stderr: go: go.mod requires go >= 1.23.0 (running go 1.22.10; GOTOOLCHAIN=local)" |
|
Are we ready to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add v6e accelerator-awareness & account for
cloud.google.com/reservation-projectnode selector.