Duplicates charts to rag folder so the Marketplace release can work #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
genlu2011
approved these changes
Dec 5, 2024
leroyjb
pushed a commit
to leroyjb/ai-on-gke
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we release RAG QSS on Marketplace, we zip the whole rag folder and upload it to a GCS bucket so Marketplace can use it to do terraform apply. With the current setup to install
gmp-enginefor rag, the Marketplace will not be able to find the charts since it's not in the GCS. It is also not possible to modify the chart path to point to the github patch like what we do for the other modules in RAG, because it is not supported with the current setup of thegmp-enginechart. As a workaround, duplicating the charts to the rag folder so it can be zipped together and uploaded to GCS.