chore: Drop notify on failure, update deps (#486)

GoogleCloudPlatform · Dec 8, 2024 · e80b2da · e80b2da
1 parent 818477f
commit e80b2da
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 74 deletions.
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -473,21 +473,3 @@ jobs:
         run: flutter analyze
         if: "always() && steps.examples_fullstack_frontend_pub_upgrade.conclusion == 'success'"
         working-directory: examples/fullstack/frontend
-  job_007:
-    name: Notify failure
-    runs-on: ubuntu-latest
-    if: "(github.event_name == 'push' || github.event_name == 'schedule') && failure()"
-    steps:
-      - run: |
-          curl -H "Content-Type: application/json" -X POST -d \
-            "{'text':'Build failed! ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}'}" \
-            "${CHAT_WEBHOOK_URL}"
-        env:
-          CHAT_WEBHOOK_URL: "${{ secrets.CHAT_WEBHOOK_URL }}"
-    needs:
-      - job_001
-      - job_002
-      - job_003
-      - job_004
-      - job_005
-      - job_006
diff --git a/.github/workflows/unit.yml b/.github/workflows/unit.yml
@@ -359,22 +359,3 @@ jobs:
         run: dart test
         if: "always() && steps.google_cloud_pub_upgrade.conclusion == 'success'"
         working-directory: google_cloud
-  job_008:
-    name: Notify failure
-    runs-on: ubuntu-latest
-    if: "(github.event_name == 'push' || github.event_name == 'schedule') && failure()"
-    steps:
-      - run: |
-          curl -H "Content-Type: application/json" -X POST -d \
-            "{'text':'Build failed! ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}'}" \
-            "${CHAT_WEBHOOK_URL}"
-        env:
-          CHAT_WEBHOOK_URL: "${{ secrets.CHAT_WEBHOOK_URL }}"
-    needs:
-      - job_001
-      - job_002
-      - job_003
-      - job_004
-      - job_005
-      - job_006
-      - job_007
diff --git a/functions_framework/lib/src/cloud_event.g.dart b/functions_framework/lib/src/cloud_event.g.dart
diff --git a/functions_framework/pubspec.yaml b/functions_framework/pubspec.yaml
@@ -24,5 +24,5 @@ dev_dependencies:
   build_runner: ^2.2.1
   build_verify: ^3.0.0
   dart_flutter_team_lints: ^3.0.0
-  json_serializable: ^6.6.0
+  json_serializable: ^6.9.0
   test: ^1.21.6
diff --git a/integration_test/test/cli_test.dart b/integration_test/test/cli_test.dart
@@ -157,7 +157,7 @@ void main() {
       await expectLater(
         proc.stderr,
         emitsInOrder([
-          'Could not find an option named "bob".',
+          'Could not find an option named "--bob".',
           ...LineSplitter.split(_usage),
         ]),
       );
@@ -193,7 +193,7 @@ void main() {
       await expectLater(
         proc.stderr,
         emitsInOrder([
-          '"foo" is not an allowed value for option "signature-type".',
+          '"foo" is not an allowed value for option "--signature-type".',
           ...LineSplitter.split(_usage),
         ]),
       );

diff --git a/mono_repo.yaml b/mono_repo.yaml
@@ -25,16 +25,3 @@ github:
       name: Dart Unit CI
       stages:
       - unit_test
-
-  on_completion:
-  - name: "Notify failure"
-    runs-on: ubuntu-latest
-    # Run only if other jobs have failed and this is a push or scheduled build.
-    if: (github.event_name == 'push' || github.event_name == 'schedule') && failure()
-    steps:
-    - run: >
-        curl -H "Content-Type: application/json" -X POST -d \
-          "{'text':'Build failed! ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}'}" \
-          "${CHAT_WEBHOOK_URL}"
-      env:
-        CHAT_WEBHOOK_URL: ${{ secrets.CHAT_WEBHOOK_URL }}