Fix wrong cloudsql/WARN/2023_003 MQL query #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request. Please check to be sure you have completed the contribution license agreement so we can merge your change into the repository |
|
LGTM, thanks for the fix |
junggil
added
the
ready to pull
copybara-service
bot
merged commit 01878e5
into
GoogleCloudPlatform:main
4 checks passed
ropeck
pushed a commit
that referenced
this pull request
Feb 26, 2024
This changes the MQL query for cloudsql/WARN/2023_003 from `aggregate` (which adds the value up to the thousands) to `max` which I assume was the intended way this query works. Also, I fixed two small typos I found when I accidentally opened the wrong file. Edit: Fixes #74 Merge da4af2a into 620a060 Closes #75 FUTURE_COPYBARA_INTEGRATE_REVIEW=#75 from m3adow:fix/correct-2023_003-mql-query da4af2a ORIGINAL_AUTHOR=Till Wiese <1872304+m3adow@users.noreply.github.com> GitOrigin-RevId: b9bebbf Change-Id: I4a206f4c8ede86c8f650ce8b7dbb0483b97ab870
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the MQL query for cloudsql/WARN/2023_003 from
aggregate(which adds the value up to the thousands) tomaxwhich I assume was the intended way this query works.Also, I fixed two small typos I found when I accidentally opened the wrong file.
Edit: Fixes #74