Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gatewaypolicies CRD schema #132

Conversation

kalindudc
Copy link
Contributor

Closes: #130

Description

This PR adds the gcpgatewaypolicies.networking.gke.io introduced with https://cloud.google.com/kubernetes-engine/docs/how-to/configure-gateway-resources#configure_global_access. This CRD was grabbed directly from a GKE 1.24 cluster with gateway API.

❯ kcl get crd gcpgatewaypolicies.networking.gke.io
NAME                                   CREATED AT
gcpgatewaypolicies.networking.gke.io   2023-03-17T15:13:00Z

@google-cla
Copy link

google-cla bot commented Jun 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kalindudc kalindudc force-pushed the kalindudc/gcp-gateway-policies-schema branch from 7962b81 to b1047b1 Compare June 20, 2023 20:11
@boredabdel
Copy link
Member

Hi @kalindudc

I would be happy to review this PR but you need to sign the Google CLA https://cla.developers.google.com/clas

@kalindudc
Copy link
Contributor Author

kalindudc commented Jul 18, 2023

Hi @boredabdel, I believe I have already signed this. I re-signed it today.

image image

Copy link
Member

@boredabdel boredabdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boredabdel boredabdel merged commit ef2cea6 into GoogleCloudPlatform:main Jul 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GCPGatewayPolicy Gateway CRDs example
2 participants