Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update apiVersion for custom-http-hc-ingress #134

Closed
wants to merge 2 commits into from
Closed

Update apiVersion for custom-http-hc-ingress #134

wants to merge 2 commits into from

Conversation

sawsa307
Copy link
Contributor

@sawsa307 sawsa307 commented Jul 11, 2023 •
edited
Loading

  1. Update apiVersion from networking.k8s.io/v1beta1 to networking.k8s.io.
  2. Explicitly specify ingress.class annotation since it won't be automatically populated, and is useful to distinguish internal/external lb.
  3. Update ingress rule paths.

@sawsa307
Update apiVersion for custom-http-hc-ingress
043f3aa 
1. Update apiVersion from networking.k8s.io/v1beta1 to
   networking.k8s.io.
2. Explicitly specify ingress.class annotation since it won't
   automatically populated, and is useful to distinguish
   internal/external lb.
3. Update ingress rule paths.
@sawsa307
Copy link
Contributor Author

/assign @bowei @swetharepakula

@sawsa307
Copy link
Contributor Author

cc @bowei @swetharepakula

@bowei
Merge pull request GoogleCloudPlatform#134 from sawsa307/update-custo…
47454f6 
…m-http-hc-recipe

Update apiVersion for custom-http-hc-ingress
@sawsa307 sawsa307 closed this Jul 12, 2023
@sawsa307 sawsa307 deleted the update-custom-http-hc-recipe branch September 22, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sawsa307 @bowei