Update README for ingress-cloudarmor #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowei
reviewed
Jul 14, 2023
| Using allowed IP 34.83.21.159: | ||
| ``` | ||
| curl 34.160.135.174/whereami | ||
| {"cluster_name":"blueprint-gke-1","gce_instance_id":"6716870310474717637","gce_service_account":"324901199046-compute@developer.gserviceaccount.com","host_header":"34.160.135.174","pod_name":"whereami-59588795bb-7dx2c","pod_name_emoji":"\ud83c\udf24","project_id":"cheungdavid-gke-dev","timestamp":"2023-07-13T23:12:59","zone":"us-west1-a"} |
There was a problem hiding this comment.
let's scrub things like the exact service account names etc.
and your name
chuengdavid-gke-dev
Can you make sure that this is done for the rest of the text.
|
Reviewed -- see comment above. |
sawsa307
force-pushed
the
update-ingress-cloud-armor-recipe
branch
2 times, most recently
from
2bc9e5e
to
7b52455
Compare
Add example outputs and details for validation in the README. Also update ingress version.
sawsa307
force-pushed
the
update-ingress-cloud-armor-recipe
branch
from
7b52455
to
f165728
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add example outputs and details for validation in the README. Also update ingress version.