Create test for ingress for custom default backend. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sawsa307
force-pushed
the
test-ing-custom-default-be
branch
8 times, most recently
from
5d5e174
to
d56a07d
Compare
sawsa307
force-pushed
the
test-ing-custom-default-be
branch
10 times, most recently
from
c37101b
to
e3ef669
Compare
Add setup for network and subnet, and make sure the cluster is created in the given network and subnet. Add test/cleanup.sh to cleanup resouces. It uses the same value for env in test.
sawsa307
force-pushed
the
test-ing-custom-default-be
branch
from
e3ef669
to
34624c1
Compare
|
I thought the purpose of the code is to test the YAMLs checked in, not to write more e2e tests? |
Do you mean we only want to check if the yaml files are syntactically correct? We don't need to create and validate the resources created by yaml? |
Yes it is getting into a more e2e test format, but we might fail to check many cases if we only check the yaml creates the corresponding objects, so validating traffic would be more a comprehensive check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create test for ingress for custom default backend.