Add TestHelloWorld to set up prow, and add more loggings for boskos project rental. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a trivial test to test prow work flow.
sawsa307
force-pushed
the
create-test-hw
branch
from
9dcb3f2
to
7a2dfb5
Compare
bowei
reviewed
Aug 15, 2023
test/utils.go
Outdated
| }, | ||
| func(err error) bool { return true }, | ||
| func() error { | ||
| klog.Info("Trying to acuquire boskos project...") |
test/utils.go
Outdated
| @@ -60,7 +61,7 @@ func getBoskosProject(resourceType string) *common.Resource { | |||
| }, | |||
| ) | |||
| if err != nil { | |||
| klog.Fatalf("timed out trying to acquire boskos project") | |||
| klog.Fatalf("timed out trying to acquire boskos project: %v", err) | |||
There was a problem hiding this comment.
Error trying to acquire boskos: %v
| Factor: 1.0, | ||
| Steps: 10, | ||
| Steps: 30, |
There was a problem hiding this comment.
This is 30 minutes. Do we want to wait this long? also should the retry by faster?
Why not do:
10*time.Second
Steps 30
Do we have evidence that the values you are recommending make sense
There was a problem hiding this comment.
I don't see anywhere suggesting an estimate of how long it takes, but this is the setup using in https://github.com/GoogleCloudPlatform/gcs-fuse-csi-driver/blob/7485ad00b362a6172c2bceddcdfba8688a8be0e6/test/e2e/utils/project.go#L35. I think we can start with 5 mins and increase if that's not enough.
Increase wait time since project rental currently fails for timeout and doesn't include errors.
sawsa307
force-pushed
the
create-test-hw
branch
from
7a2dfb5
to
d95369d
Compare
bowei
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TestHelloWorld to set up prow, and add more loggings for boskos project rental.