Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Java Contrib submodule and update to use java 17 in build #1352

Merged
merged 18 commits into from
Jul 28, 2023
Merged

Update Java Contrib submodule and update to use java 17 in build #1352

merged 18 commits into from
Jul 28, 2023

Conversation

dehaansa
Copy link
Contributor

Description

Update to latest head of java-contrib submodule. The goal of this is to pull in the updates that address a customer issue where metrics were still returned after a target went down. open-telemetry/opentelemetry-java-contrib#949

Related issue

#1183

How has this been tested?

As of yet untested, opening the PR to run through integration tests & ensure build process works with latest JMX Metrics Gatherer while testing happens in parallel.

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

igorpeshansky
igorpeshansky reviewed Jul 27, 2023
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial thoughts.

Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@dehaansa dehaansa changed the title Update Java Contrib submodule Update Java Contrib submodule and update to use java 17 in build Jul 27, 2023
@dehaansa dehaansa marked this pull request as ready for review July 27, 2023 19:24
@dehaansa dehaansa requested a review from igorpeshansky July 27, 2023 20:33
igorpeshansky
igorpeshansky reviewed Jul 28, 2023
View reviewed changes
dockerfiles/compile.go Outdated Show resolved Hide resolved
dockerfiles/compile.go Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
igorpeshansky
igorpeshansky approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@igorpeshansky igorpeshansky merged commit 7154f14 into GoogleCloudPlatform:master Jul 28, 2023
@dehaansa dehaansa deleted the update-jmx-metrics-receiver branch July 28, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dehaansa @igorpeshansky