fix: Descendants entities losing database ID from parent (#3142) (#3156)

* fix: need to also send database ID when migrating keys from ancestor to child
GoogleCloudPlatform · Sep 4, 2024 · 02a1e65 · 02a1e65
1 parent 96890b8
commit 02a1e65
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/...ata-datastore/src/main/java/com/google/cloud/spring/data/datastore/core/util/KeyUtil.java b/...ata-datastore/src/main/java/com/google/cloud/spring/data/datastore/core/util/KeyUtil.java
@@ -46,6 +46,7 @@ public static Key getKeyWithoutAncestors(Key entityKey) {
           Key.newBuilder(entityKey.getProjectId(), entityKey.getKind(), entityKey.getId());
     }
     ancestorLookupKey.setNamespace(entityKey.getNamespace());
+    ancestorLookupKey.setDatabaseId(entityKey.getDatabaseId());
 
     return ancestorLookupKey.build();
   }

diff --git a/...datastore/src/test/java/com/google/cloud/spring/data/datastore/core/util/KeyUtilTest.java b/...datastore/src/test/java/com/google/cloud/spring/data/datastore/core/util/KeyUtilTest.java
@@ -47,4 +47,29 @@ void testRemoveAncestors_IdKeys() {
     Key processedKey = KeyUtil.getKeyWithoutAncestors(idKey);
     assertThat(processedKey.getAncestors()).isEmpty();
   }
+
+  @Test
+  void testAncestorKeys_containsAllDataStoreMetaData() {
+    String projectId = "project-id";
+    String kind = "kind";
+    Long id = 13L;
+    String databaseId = "database-id";
+    String namespace = "namespace";
+
+    Key idKey =
+        Key.newBuilder(projectId, kind, id, databaseId)
+            .setNamespace(namespace)
+            .addAncestor(PathElement.of("person", 22L))
+            .addAncestor(PathElement.of("person", 18L))
+            .build();
+
+    Key processedKey = KeyUtil.getKeyWithoutAncestors(idKey);
+
+    assertThat(processedKey.getAncestors()).isEmpty();
+    assertThat(processedKey.getId()).isEqualTo(id);
+    assertThat(processedKey.getKind()).isEqualTo(kind);
+    assertThat(processedKey.getDatabaseId()).isEqualTo(databaseId);
+    assertThat(processedKey.getNamespace()).isEqualTo(namespace);
+    assertThat(processedKey.getProjectId()).isEqualTo(projectId);
+  }
 }