Skip to content

Commit

Permalink
chore: fix spring-cloud-generator scripts after refactor (#1999)
Browse files Browse the repository at this point in the history
* Invoking scripts/generate-library-list.sh missed a flag for passing the google-cloud-java version to checkout
  • Loading branch information
emmileaf authored Jul 5, 2023
1 parent 8fafffd commit 186a150
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions spring-cloud-generator/scripts/generate-library-list.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ do
done
echo "Monorepo tag: $commitish";

if [[ -z "$commitish" ]]; then
echo "Missing google-cloud-java commitish to checkout"
exit 1
fi

# download the monorepo, need to loop through metadata there
git clone https://github.com/googleapis/google-cloud-java.git

Expand Down
2 changes: 1 addition & 1 deletion spring-cloud-generator/scripts/generate-steps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function compute_monorepo_version() {
# $1 - Monorepo version tag (or committish)
function generate_libraries_list(){
cd ${SPRING_GENERATOR_DIR}
bash scripts/generate-library-list.sh $1
bash scripts/generate-library-list.sh -c $1
}

# When bazel prepare, build, or post-processing step fails, stores the captured stdout and stderr to a file
Expand Down

0 comments on commit 186a150

Please sign in to comment.