Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: Use low-reputation billing account #45

Merged
merged 16 commits into from
Jul 19, 2023
Merged

Conversation

grayside
Copy link
Contributor

Testing with this billing account will be more accurate to the constraints experienced by Solutions Catalog users.

Failure modes we may experience include errors that appear similar to org constraint or quota limits.

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • Added steps to reproduce the changes in this pull request
  • Added relevant testing in this pull request
  • Please merge this PR for me once it is approved.

Testing with this billing account will be more accurate to the constraints experienced by Solutions Catalog users.

Failure modes we may experience include errors that appear similar to org constraint or quota limits.
@grayside
Copy link
Contributor Author

grayside commented Jun 6, 2023

I'm not sure what the state of testing is in this repository, but no end-to-end tests were run. Do not merge this PR, as we want to ensure a passing baseline before adding the billing constraint.

@grayside grayside marked this pull request as draft June 6, 2023 21:42
@donmccasland donmccasland marked this pull request as ready for review June 14, 2023 16:40
@donmccasland
Copy link
Member

I will make sure cfint triggers are added for this repo and re-run.

@donmccasland donmccasland requested review from a team and glasnt as code owners June 15, 2023 14:56
@donmccasland
Copy link
Member

/gcbrun

@rogerthatdev
Copy link
Contributor

/gcbrun

@grayside
Copy link
Contributor Author

Could we move most of the test setup out of this PR or remove low reputation for now? I want to be able to evaluate adding low reputation on top of existing e2e tests.

@rogerthatdev rogerthatdev marked this pull request as draft June 27, 2023 18:20
@donmccasland donmccasland marked this pull request as ready for review July 19, 2023 19:52
@donmccasland donmccasland merged commit cca8d37 into main Jul 19, 2023
8 checks passed
@donmccasland donmccasland deleted the testing-low-rep branch July 19, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants