Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added zone to variables #81

Closed
wants to merge 2 commits into from

Conversation

alebrozzo
Copy link

Description

Adds a new variable to infra/variables.tf for the zone and defaults to the region's -a zone

Steps to reproduce: Create a new "Dynamic web application with JavaScript" sample deploy using Terraform CLI

Fixes #80

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • Added steps to reproduce the changes in this pull request
  • Added relevant testing in this pull request
  • Please merge this PR for me once it is approved.

@google-cla
Copy link

google-cla bot commented Oct 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rogerthatdev
Copy link
Contributor

Thanks for your contribution @alebrozzo!

The lint check doesn't like that we're declaring a variable for zone without using it:

Warning: variable "zone" is declared but not used (terraform_unused_declarations)

  on variables.tf line 52:
  52: variable "zone" {

See if there are resources that we can use the zone variable and add it there.

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Dec 22, 2023
@github-actions github-actions bot closed this Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "zone" variable in variables.tf
3 participants