Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate images from GCR to AR #153

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: Migrate images from GCR to AR #153

wants to merge 3 commits into from

Conversation

NimJay
Copy link
Contributor

@NimJay NimJay commented Sep 16, 2024

Background

  • We need to migrate away from Google Container Registry (GCR) and use Artifact Registry (AR) instead.
  • This JSS (Jump Start Solution) currently deploys three different container images:
    • gcr.io/sic-container-repo/todo-fe
    • gcr.io/sic-container-repo/todo-api
    • gcr.io/sic-container-repo/todo-api-postgres:latest

Changes in this pull-request

  • I’ve pushed (copied over) each image to an Artifact Registry repo in the google-samples project.
    • gcr.io/sic-container-repo/todo-fe
      • to us-docker.pkg.dev/google-samples/containers/jss/three-tier-web-app-fe:v0.0.1
    • gcr.io/sic-container-repo/todo-api
      • to us-docker.pkg.dev/google-samples/containers/jss/three-tier-web-app-api:v0.0.1
    • gcr.io/sic-container-repo/todo-api-postgres:latest
      • us-docker.pkg.dev/google-samples/containers/jss/three-tier-web-app-api-postgres:v0.0.1
  • I don’t have access to the sic-container-repo project (so I couldn’t just migrate the gcr.io URLs to Artifact Registry.) Plus, other JSSs use the google-samples project for their images (e.g., this image).

How to review

  1. You’ll see that the integration tests are passing (in the GitHub checks below).
  2. Optional: You can use docker inspect to extract the RootFS.Layers value and check that the hashes match:
docker inspect gcr.io/sic-container-repo/todo-fe
docker inspect  us-docker.pkg.dev/google-samples/containers/jss/three-tier-web-app-fe:v0.0.1
# Layers' sha256 hashes should be identical

docker inspect gcr.io/sic-container-repo/todo-api
docker inspect  us-docker.pkg.dev/google-samples/containers/jss/three-tier-web-app-todo-api:v0.0.1
# Layers' sha256 hashes should be identical

docker inspect gcr.io/sic-container-repo/todo-api-postgres
docker inspect  us-docker.pkg.dev/google-samples/containers/jss/three-tier-web-app-api-postgres:v0.0.1
# Layers' sha256 hashes should be identical

The use of the docker inspect command is suggested in this StackOverflow post.

@NimJay NimJay marked this pull request as ready for review September 16, 2024 20:57
@NimJay NimJay requested review from tpryan and a team as code owners September 16, 2024 20:57
@NimJay NimJay self-assigned this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant