Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Remove reference to Container Registry and redundant option #218

Merged
merged 1 commit into from
Sep 17, 2024
Merged

docs: Remove reference to Container Registry and redundant option #218

merged 1 commit into from
Sep 17, 2024

Conversation

NimJay
Copy link
Contributor

@NimJay NimJay commented Sep 16, 2024

Background:

  • We need to replace references to Container Registry with Artifact Registry.

Changes in this pull-request:

  • I'm updating the docs in the src/frontend/ folder to refer to Artifact Registry instead of Container Registry.
  • I'm removing a deployment option that isn't necessary.

NimJay
NimJay commented Sep 16, 2024
View reviewed changes
src/frontend/README.md

#### Option 2. Build a container using Google Cloud Build
Copy link
Contributor Author

@NimJay NimJay Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm removing option 2. Users can just use option 1 (gcloud run deploy ... --source) with the --source argument to build and deploy in a single step.

@NimJay
Copy link
Contributor Author

NimJay commented Sep 17, 2024

Hi @saraford, when you find time (not urgent), could you please review/approve this pull-request?
Thank you.

@NimJay
Copy link
Contributor Author

NimJay commented Sep 17, 2024

Thanks, Sara, for the super quick review and approve! Merging.

@NimJay NimJay merged commit eb2db69 into main Sep 17, 2024
9 checks passed
@NimJay NimJay deleted the nimjay-container-registry branch September 17, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraford saraford saraford approved these changes

@xsxm xsxm Awaiting requested review from xsxm xsxm is a code owner

@ivanmkc ivanmkc Awaiting requested review from ivanmkc ivanmkc is a code owner

@balajismaniam balajismaniam Awaiting requested review from balajismaniam balajismaniam is a code owner

@donmccasland donmccasland Awaiting requested review from donmccasland donmccasland is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NimJay @saraford