Skip to content

Commit

Permalink
Merge pull request #573 from Gosrock/fix/kakao-redirect
Browse files Browse the repository at this point in the history
fix : 카카오 콜백 url 에 // 중복으로 들어간 문제 해결, docker-compose. ->> docker compose
  • Loading branch information
ImNM authored Dec 1, 2024
2 parents dc23c39 + 9000272 commit 0eb2535
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/BuildApiServer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
#테스트 수행용 도커 컴포즈
- name: Start containers
run: docker-compose up -d
run: docker compose up -d

- name: Gradle Build
uses: gradle/gradle-build-action@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/BuildBatchServer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
#테스트 수행용 도커 컴포즈
- name: Start containers
run: docker-compose up -d
run: docker compose up -d

- name: Gradle Build
uses: gradle/gradle-build-action@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/BuildSocketServer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
#테스트 수행용 도커 컴포즈
- name: Start containers
run: docker-compose up -d
run: docker compose up -d

- name: Gradle Build
uses: gradle/gradle-build-action@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
run: ./gradlew spotlessCheck

- name: Start containers
run: docker-compose up -d
run: docker compose up -d

- name: test and analyze
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dev-merged-test-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
run: ./gradlew spotlessCheck

- name: Start containers
run: docker-compose up -d
run: docker compose up -d

- name: test and analyze
env:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,17 @@ public OauthLoginLinkResponse getKakaoOauthLink(
// 스테이징, prod 서버에 배포된 클라이언트에 해당
if (referer.contains(host)) {
log.info("/oauth/kakao" + host);
String format = String.format("https://%s/", host);
String format = String.format("https://%s", host);
if (referer.contains("admin")) {
// 프론트 개발자가 로컬에서 개발 테스트 할 때 해당 https://두둥.com/admin/
return registerUseCase.getKaKaoOauthLink(format + "admin");
// 프론트 개발자가 로컬에서 개발 테스트 할 때 해당 https://dudoong.com/admin
return registerUseCase.getKaKaoOauthLink(format + "/admin");
}
return registerUseCase.getKaKaoOauthLink(format);
} else if (referer.contains("5173")) {
// 프론트 개발자가 로컬에서 개발 테스트 할 때 해당 https://localhost:5173/admin/
return registerUseCase.getKaKaoOauthLink(referer + "admin");
// 프론트 개발자가 로컬에서 개발 테스트 할 때 해당 https://localhost:5173/admin
return registerUseCase.getKaKaoOauthLink(referer + "/admin");
}
// 프론트 개발자가 로컬에서 개발 테스트 할 때 해당 https://localhost:3000/
// 프론트 개발자가 로컬에서 개발 테스트 할 때 해당 https://localhost:3000
return registerUseCase.getKaKaoOauthLink(referer);
}

Expand All @@ -98,17 +98,17 @@ public OauthTokenResponse getCredentialFromKaKao(
// 스테이징, prod 서버에 배포된 클라이언트에 해당
if (referer.contains(host)) {
log.info("/oauth/kakao" + host);
String format = String.format("https://%s/", host);
String format = String.format("https://%s", host);
if (referer.contains("admin")) {
return registerUseCase.getCredentialFromKaKao(code, format + "admin");
return registerUseCase.getCredentialFromKaKao(code, format + "/admin");
}
return registerUseCase.getCredentialFromKaKao(code, format);
} else if (referer.contains("5173")) {
return registerUseCase.getCredentialFromKaKao(code, referer + "admin");
// 프론트 개발자가 로컬에서 어드민 테스트 할 때 해당 https://localhost:5173/admin
return registerUseCase.getCredentialFromKaKao(code, referer + "/admin");
}
// 프론트 개발자가 로컬에서 개발 테스트 할 때 해당 https://localhost:3000/admin
return registerUseCase.getCredentialFromKaKao(code, referer);

// 프론트 개발자가 로컬에서 개발 테스트 할 때 해당 https://localhost:3000/
}

@Operation(summary = "개발용 회원가입입니다 클라이언트가 몰라도 됩니다.", deprecated = true)
Expand Down

0 comments on commit 0eb2535

Please sign in to comment.