Merge pull request #54 from Gottox/fix/clang-tidy

resolve issues found by clang-tidy
Gottox · Aug 21, 2023 · cf1d5b6 · cf1d5b6
2 parents ed2b8b2 + 84bdd1d
commit cf1d5b6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/lib/tree/walker.c b/lib/tree/walker.c
@@ -354,9 +354,6 @@ tree_walker_resolve(
 				if (rv < 0) {
 					goto out;
 				}
-				if (sqsh_tree_walker_type(walker) == SQSH_FILE_TYPE_DIRECTORY) {
-					is_dir = true;
-				}
 				is_dir = sqsh_tree_walker_type(walker) ==
 						SQSH_FILE_TYPE_DIRECTORY;
 				break;

diff --git a/test/reader/reader.c b/test/reader/reader.c
@@ -547,9 +547,10 @@ test_reader_extend_size_till_end(void) {
 	data = sqsh__reader_data(&reader);
 	assert(sqsh__reader_size(&reader) == 12);
 	assert(memcmp(data, "456789ABCDEF", 12) == 0);
+	assert(rv == 0);
 
-	// rv = sqsh__reader_advance(&reader, 0, 13);
-	// assert(rv == -SQSH_ERROR_OUT_OF_BOUNDS);
+	rv = sqsh__reader_advance(&reader, 0, 13);
+	assert(rv == -SQSH_ERROR_OUT_OF_BOUNDS);
 
 	sqsh__reader_cleanup(&reader);
 }