reader: reimplementation the reader without _skip #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gottox
force-pushed
the
reader2
branch
4 times, most recently
from
1b1cbcc
to
f2fbcb3
Compare
This reverts commit b3f42f9.
Gottox
force-pushed
the
reader2
branch
3 times, most recently
from
e82af48
to
31a6519
Compare
Currently, there is an issue with a subtle incompatibility between different iterators. The old SqshReader expected, that all blocks (except the last one) are of the same size. This is not true for SqshFileIterator when iterating over sparse files. The new SqshReader2 does not have this limitation.
This fixes a bug when the data storage wrongfully points to the iterator when it actually needs to read from the buffer. A safeguard `assert()` call has been added to the `reader_fill_buffer()` to detect this error in case of regression. Also a test case has been added to reproduce this error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is an issue with a subtle incompatibility between
different iterators. The old SqshReader expected, that all blocks
(except the last one) are of the same size. This is not true for
SqshFileIterator when iterating over sparse files. The new
SqshReader2 does not have this limitation.