directory_iterator: fix wrong free, add tests #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
during one of the last refactorings of the heap constructors, there was a bug introduced that caused a free of the wrong pointer. This commit fixes that bug, makes the wrongly freed pointer const to yield compiler warnings on misuse, and adds a test to make sure it doesn't happen again.
Gottox
force-pushed
the
fix/directory-iterator-wrong-free
branch
from
8fbdea7
to
f5c879f
Compare
Gottox
added a commit
that referenced
this pull request
Aug 17, 2023
directory_iterator: fix wrong free, add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during one of the last refactorings of the heap constructors, there was a bug introduced that caused a free of the wrong pointer. This commit fixes that bug, makes the wrongly freed pointer
constto yield compiler warnings on misuse, and adds a test to make sure it doesn't happen again.