Change signature of the _next method of iterators #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the iterator's next function returns an int which returns >0 on success, 0 on end of iterator and <0 on error. This commit changes the generic iterator implementation to return a bool instead of an int. The bool is true if the iterator has more data and false if the iterator is at the end. The error code is now passed as a pointer parameter to the next function.
This commit changes the return type of sqsh_file_iterator_next() from int to bool. The return value is now used to indicate whether there is more data to read from the file iterator. The error code is now stored in a pointer to an int instead of being returned directly.
This commit changes the return type of sqsh__directory_index_iterator_next() from int to bool. The return value is now used to indicate whether there is more data to read from the directory index iterator. The error code is now stored in a pointer to an int instead of being returned directly.
This commit changes the return type of sqsh__map_iterator_next() from int to bool. The return value is now used to indicate whether there is more data to read from the map iterator. The error code is now stored in a pointer to an int instead of being returned directly.
This commit changes the return type of sqsh__metablock_iterator_next() from int to bool. The return value is now used to indicate whether there is more data to read from the metablock iterator. The error code is now stored in a pointer to an int instead of being returned directly.
This commit changes the return type of sqsh_directory_iterator_next() from int to bool. The return value is now used to indicate whether there is more data to read from the directory iterator. The error code is now stored in a pointer to an int instead of being returned directly.
This commit changes the return type of sqsh_xattr_iterator_next() from int to bool. The return value is now used to indicate whether there is more data to read from the xattr iterator. The error code is now stored in a pointer to an int instead of being returned directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.