Change names of files with the same path - this time by Transformer

[amorfis]

Hello,

What about this one? ;)

[amorfis]

Hello,
As you proposed, I moved the file renaming functionality to the Transformer. Could you check it, and maybe merge?

[johnrengelman]

Won't mergedJar.name work fine for this? Seems like we've made a bunch of changes that aren't really need as the information is available from the existing API.

[johnrengelman]

On that note, I'd prefer if you kept the changes to a minimum. The variable renames makes this a lot harder to review because it's harder to see what the actually change was.

[amorfis]

Ok, thanks for looking at this! WRT variables naming, I was really lost with "archive", it was never clear to me if it is the .jar we are merging into fat jar, or far jar itself.
WRT redundancy, I'll look at this, but AFAIR there was no jar file path in mergedJar

[johnrengelman]

http://docs.oracle.com/javase/7/docs/api/java/util/zip/ZipFile.html#getName()

[johnrengelman]

I'd prefer to name the variable sourceJar then.

[johnrengelman]

Or sourceArchive

[ugoscaiella]

Hi,
What's the status of this PR?

I was trying to restore the possibility to filter-out files from certain jars, a feature that was supported in the past (according to the old readme, but I never tested it):

shadow {
    filter('org.apache.maven.its.shade.fac:a') {
        include '**/a.properties'
    }
    filter('org.apache.maven.its.shade.fac:b:client') {
        exclude 'org/apache/*'
        exclude 'org/apache/maven/b/'
    }
    filter('*:*') {
        exclude 'org/*'
    }
}

I tried to implement this using a Transformer, but I think that this PR is required, because the transformer API does not have any information about the path or the name of the jar which the file comes from...
is it right?