Skip to content

Remove clippy for macos #356

Remove clippy for macos

Remove clippy for macos #356

Triggered via push October 30, 2024 22:07
Status Success
Total duration 44s
Artifacts
prettier-tsc-eslint-checks
32s
prettier-tsc-eslint-checks
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 1 warning
called `unwrap` on `response` after checking its variant with `is_some`: src/web.rs#L40
error: called `unwrap` on `response` after checking its variant with `is_some` --> src/web.rs:40:12 | 39 | if response.is_some() { | --------------------- help: try: `if let Some(..) = response` 40 | return response.unwrap().status().as_str() == "200"; | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap = note: `-D clippy::unnecessary-unwrap` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unnecessary_unwrap)]`
current MSRV (Minimum Supported Rust Version) is `1.57.0` but this item is stable since `1.58.0`: src/system_helpers.rs#L697
error: current MSRV (Minimum Supported Rust Version) is `1.57.0` but this item is stable since `1.58.0` --> src/system_helpers.rs:697:18 | 697 | while java_bin.is_symlink() { | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
current MSRV (Minimum Supported Rust Version) is `1.57.0` but this item is stable since `1.58.0`: src/system_helpers.rs#L677
error: current MSRV (Minimum Supported Rust Version) is `1.57.0` but this item is stable since `1.58.0` --> src/system_helpers.rs:677:18 | 677 | while java_bin.is_symlink() { | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: `-D clippy::incompatible-msrv` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::incompatible_msrv)]`
method `in_terminal_noclose` is never used: src/system_helpers.rs#L69
error: method `in_terminal_noclose` is never used --> src/system_helpers.rs:69:6 | 67 | trait InTerminalEmulator { | ------------------ method in this trait 68 | fn in_terminal(&self) -> Self; 69 | fn in_terminal_noclose(&self) -> Self; | ^^^^^^^^^^^^^^^^^^^
method `as_root` is never used: src/system_helpers.rs#L48
error: method `as_root` is never used --> src/system_helpers.rs:48:6 | 47 | pub trait AsRoot { | ------ method in this trait 48 | fn as_root(&self) -> Self; | ^^^^^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]`
prettier-tsc-eslint-checks
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/