Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused GRAYLOG_DATANODE_ROOT_PASSWORD_SHA2 from datanode compose #78

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unused GRAYLOG_DATANODE_ROOT_PASSWORD_SHA2 from datanode compose #78

wants to merge 2 commits into from

Conversation

todvora
Copy link

@todvora todvora commented Oct 17, 2024

Merge only after updating to 6.1! Related to Graylog2/graylog-docker#278

Notes for Reviewers

  • The commit history must be preserved - please use the rebase-merge or standard merge option instead of squash-merge
  • Sync up with the author before merging

@todvora todvora requested a review from bernd October 17, 2024 10:15
bernd
bernd requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@todvora The variable is used in more files.

@todvora
Copy link
Author

todvora commented Oct 30, 2024

@bernd sorry, I focused only on the open part. Fixed now.

bernd
bernd requested changes Oct 30, 2024
View reviewed changes
open-core/docker-compose.yml Outdated Show resolved Hide resolved
bernd
bernd requested changes Oct 30, 2024
View reviewed changes
open-core/docker-compose.yml Outdated Show resolved Hide resolved
open-core/docker-compose.yml Outdated Show resolved Hide resolved
@todvora todvora force-pushed the fix/remove_password_hash_datanode branch from 9fa49fe to fe8a313 Compare October 31, 2024 07:06
@todvora todvora requested a review from bernd October 31, 2024 07:07
bernd
bernd approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernd bernd bernd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@todvora @bernd