-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.5 WattTime v3 Updates #547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rently copied into casdk-docs/docs to get live updates (copied and not moved so changes in main can be easily identified when rebasing once it all works)
DRAFT - Docs/docusaurus setup
Signed-off-by: Phil Huang <phil.huang@microsoft.com>
Signed-off-by: tkuramoto33 <70622977+tkuramoto33@users.noreply.github.com>
Signed-off-by: tkuramoto33 <70622977+tkuramoto33@users.noreply.github.com>
Signed-off-by: tkuramoto33 <70622977+tkuramoto33@users.noreply.github.com>
table of content Signed-off-by: Rintaro Ikeda <51394766+rinikeda@users.noreply.github.com>
Signed-off-by: Rintaro Ikeda <51394766+rinikeda@users.noreply.github.com>
Small typo ("arbon" => "Carbon") Signed-off-by: Richard Jackson <jacksorjacksor@pm.me>
Update WattTime registration link
Historical forecasts updated
I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: b9490e4 I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: b991bac I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: e4f1494 I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: b443e9e I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: ab1205d I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: 7c115fa I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: e047c9a I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: aa81382 I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: 8640c8c I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: 880fcf7 Signed-off-by: Vaughan Knight <vaughan@vaughanknight.com>
Many tests reworked, a few to go. Consolidated a lot of the hand crafted json objects into objects that get serialized as the purist JsonObject format was prone to errors - in some cases tests were passing even with bad typing.
Further test updates
…e-Foundation/carbon-aware-sdk into wattime-v3-support
…e-Foundation/carbon-aware-sdk into wattime-v3-support
Further updates, just 1 test left to remediate
…ests Updated to add authentication client to the service builder for the tests. All tests now passing.
Renaming of Balancing Authority to Region through all code and comments. This will also need updating through documentation.
Fixed spelling error in latitude
Fixed a bug where location sources were loading twice. Added a semaphore to stop any threading issues, and also stopped it loading twice in the service configuration.
Fixed typo for method name
I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: e324f36 I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: be6663c I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: 39e45a6 I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: fbfcac1 I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: 9aabd27 I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: 8127a92 I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: 4ff0151 I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: d93320f I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: 91799f7 I, Vaughan Knight <vaughan@vaughanknight.com>, hereby add my Signed-off-by to this commit: 4665813 Signed-off-by: Vaughan Knight <vaughan@vaughanknight.com>
Updates based on code review for WattTime Tests. Mostly cleanup of constants which were removed elsewhere in tests.
Cleaned up a lot of the string literals. They were causing too much fragility in the code base, and made it complex when updating the WattTime API.
More cleanup of some of the strings. Creating consistency for using the test data on parameters and not just reponses also.
Updates to documentation and changelog
…port Watt Time v3 Support
Latest azure-regions.json list Adds italynorth, polandcentral, spaincentral, mexicocentral, israelcentral, qatarcentral, brazilus, eastusstg (Also seems to remove trailing zeros in some existing coordinates) Signed-off-by: Dan Benitah <bdanuw@gmail.com>
Signed-off-by: Dan Benitah <bdanuw@gmail.com>
layout update Signed-off-by: Dan Benitah <bdanuw@gmail.com>
Update CHANGELOG.md for v1.5
Signed-off-by: Vaughan Knight <vaughan@vaughanknight.com>
danuw
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
14 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
This is the WattTime v3 update. Most notable changes that may require action are for deployment configuration, and these are minor efforts. The CA SDK API has no changed.
Added
WattTime v3 API support. This is an inplace upgrade for v2.
Removed
WattTime v2 API support due to v3 in place replacement.
Fixed
Changed
Updates for WattTime v3 API endpoint from v2, details in the ADR for WattTime v3 changes.
API
No changes
API Deployment
Due to the change for WattTime v3, there is change to the configuration for WattTime users.
With some of the changes to the code, some of the configuration will also needs to change.
BalancingAuthorityCacheTTL
RegionCacheTTL
AuthenticationBaseUrl
https://api.watttime.org/
if not set.Example below if set (note they do not have to be set)
SDK
No changes
Other
No changes
For more details, checkout #503
Checklist
Are there API Changes?
If yes, what are the expected API Changes? Please link to an API-Comparison
workflow with the API Diff.
Is this a breaking change?
If yes, what workflow does this break?
Anything else?
Other comments, collaborators, etc.
This PR Closes #<issue_number>