Add achievement tasks and world map controls #320

Sign in to view logs

Triggered via pull request May 30, 2024 23:39

GregHib

synchronize #544

achievement-tasks

Status Success

Total duration 2m 57s

Artifacts –

qodana_code_quality.yml

on: pull_request

Annotations

5 warnings and 1 notice

Local 'var' is never modified and can be declared as 'val': game/src/main/kotlin/world/gregs/voidps/world/activity/achievement/ExplorerJack.kts#L94

Variable is never modified, so it can be declared using 'val'

Constant conditions: game/src/main/kotlin/world/gregs/voidps/world/activity/achievement/ExplorerJack.kts#L103

Condition 'coins \> 100' is always true

Unused symbol: game/src/main/kotlin/world/gregs/voidps/world/activity/achievement/Tasks.kt#L173

Function "script_3223" is never used

Unused symbol: game/src/main/kotlin/world/gregs/voidps/world/interact/entity/npc/shop/BoughtItem.kt#L21

Function "itemBought" is never used

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, JetBrains/qodana-action@v2023.2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Function naming convention: game/src/main/kotlin/world/gregs/voidps/world/activity/achievement/Tasks.kt#L173

Function name `script_3223` should not contain underscores