Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enter the Abyss miniquest #532

Merged
merged 22 commits into from
May 15, 2024
Merged

Add Enter the Abyss miniquest #532

merged 22 commits into from
May 15, 2024

Conversation

GregHib
Copy link
Owner

@GregHib GregHib commented May 3, 2024

  • Add enter the abyss mini-quest
  • Add all npcs which can teleport player to essence mine
  • Add rune essence mine
  • Add collision loading and displaying to map viewer
  • Change essence mine area to avoid randomly teleporting into walls
  • Update wilderness area to remove safe-spots
  • Remove unnecessary wildcards from small essence pouch drops
  • Fix praying at chaos altar
  • Add truncation to message packets
  • Add optional search to variables command
  • Fix point within polygon check to be inclusive/include edges

Copy link

github-actions bot commented May 3, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 32.77512% with 281 lines in your changes are missing coverage. Please review.

Project coverage is 33.47%. Comparing base (142a65d) to head (b354aef).

Additional details and impacted files
Files Coverage Δ
...world/gregs/voidps/world/activity/quest/Quests.kts 57.14% <100.00%> (+3.29%) ⬆️
...voidps/world/interact/dialogue/type/NPCDialogue.kt 55.17% <0.00%> (-3.45%) ⬇️
...s/world/activity/skill/runecrafting/EssenceMine.kt 83.33% <83.33%> (ø)
...in/world/gregs/voidps/world/map/varrock/Aubury.kts 3.12% <25.00%> (+2.10%) ⬆️
.../gregs/voidps/world/map/wizards_tower/Sedridor.kts 0.48% <0.00%> (+<0.01%) ⬆️
...oidps/network/login/protocol/encode/ChatEncoder.kt 81.35% <57.14%> (-3.83%) ⬇️
...ain/kotlin/world/gregs/voidps/type/area/Polygon.kt 54.54% <76.92%> (+4.54%) ⬆️
...gregs/voidps/world/command/debug/DebugCommands.kts 2.97% <0.00%> (ø)
...oidps/world/activity/skill/prayer/PrayerAltars.kts 0.00% <0.00%> (ø)
...ld/activity/skill/runecrafting/RuneEssenceMine.kts 9.09% <9.09%> (ø)
... and 4 more

... and 16 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #532      +/-   ##
============================================
+ Coverage     33.39%   33.47%   +0.07%     
- Complexity     4619     4628       +9     
============================================
  Files          1262     1267       +5     
  Lines         41071    41460     +389     
  Branches       8731     8789      +58     
============================================
+ Hits          13715    13878     +163     
- Misses        24339    24525     +186     
- Partials       3017     3057      +40     
Components Coverage Δ
Content 25.81% <30.90%> (+0.25%) ⬆️
Engine 44.23% <ø> (ø)
Network 71.29% <57.14%> (-0.07%) ⬇️

@GregHib GregHib marked this pull request as ready for review May 13, 2024 18:39
@GregHib GregHib merged commit 64f19d8 into main May 15, 2024
5 checks passed
@GregHib GregHib deleted the enter-the-abyss branch May 15, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant