Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Deployment #36

Merged
merged 20 commits into from
Apr 13, 2021
Merged

Conversation

bodo-hugo-barwich
Copy link
Contributor

@bodo-hugo-barwich bodo-hugo-barwich commented Nov 28, 2020

This development would enable the Web Application to run in a Docker Container with a SQLite Backend.
Though It has the limitations:

  • The hypnotoad configuration from perldoc-browser.conf has no effect. (The configured port is not used but always port 3000)
  • The activity logs are not seen in the container log, only warnings are logged.

For the installation please refer to etc/docker/README

Any suggestions or issues are welcomed.

@bodo-hugo-barwich
Copy link
Contributor Author

#26 This is the first phase to enable Docker Deployment with SQLite Backend.

.gitignore Outdated
@@ -6,3 +6,17 @@ html/*
perldoc-browser.conf
perldoc-browser.sqlite*
hypnotoad.pid

#Project Files
.gitignore
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right, .gitignore is maintained in the repository so should not be ignored by git.

@Grinnz
Copy link
Owner

Grinnz commented Apr 12, 2021

Why is /etc/docker/README copied in three formats?

@bodo-hugo-barwich
Copy link
Contributor Author

Thank you for reviewing my work.
About the .gitignore file I had to include a file from my working environment to make the work easier and I initially did not want to change it.
Later I found that the Container would store its runtime generated files in this directory to and those are not part of the development generally.
If you want to go the Container Update Strategy as I set it up it will generate those files in the working directory. This is convenient for frequent changes in the working directory.
For a production environment I would rather suggest to copy the directory into the container for improved security.

@bodo-hugo-barwich
Copy link
Contributor Author

bodo-hugo-barwich commented Apr 13, 2021

I included 3 versions of the rendered README.pod mostly for online readablity convenience.
I personally found that GitHub renders the README.md better than the .pod file.
The plain text file README is convenient when you clone the project and open it in the local console environment with vim as I often do it
... Now, thinking about it you could also read the README.pod file with the perldoc command with perldoc README.pod which would also result into somewhat the same outlay.
README.md and README are just the rendered results from README.pod and I can remove them if you prefer.

@Grinnz
Copy link
Owner

Grinnz commented Apr 13, 2021

Yes, I would prefer only one file so it can be easily maintained. pod format seems good.

@bodo-hugo-barwich
Copy link
Contributor Author

I agree about the maintainability and I removed the copies of the README file

@Grinnz Grinnz merged commit 11c5e66 into Grinnz:master Apr 13, 2021
@Grinnz
Copy link
Owner

Grinnz commented Apr 13, 2021

Thank you! If you have any further developments please feel free to send additional PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants