Rename Mel::Progress::Report#moving? to #running?

GrottoPress · Sep 25, 2023 · 21ebf02 · 21ebf02
1 parent 7bd7f80
commit 21ebf02
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,7 +11,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Add `Mel::Progress::Report#pending?`
 
 ### Changed
-- Redefine `Mel::Progress::Report#moving?` to mean the progress is started and is greater than zero
+- Rename `Mel::Progress::Report#moving?` to `#running?`
+- Redefine `Mel::Progress::Report#running?` to mean the progress is started and is greater than zero
 
 ## [0.12.0] - 2023-09-19
 

diff --git a/README.md b/README.md
@@ -593,7 +593,7 @@ report.try do |_report|
   _report.value
 
   _report.failure?
-  _report.moving?
+  _report.running?
   _report.success?
 
   _report.started?

diff --git a/spec/mel/progress_spec.cr b/spec/mel/progress_spec.cr
@@ -33,7 +33,7 @@ describe Mel::Progress do
       report.try do |_report|
         _report.value.should eq(50)
         _report.description.should eq(ProgressJob.progress_description)
-        _report.moving?.should be_true
+        _report.running?.should be_true
       end
 
       Mel.start_and_stop
@@ -43,7 +43,7 @@ describe Mel::Progress do
 
       report.try do |_report|
         _report.value.should eq(80)
-        _report.moving?.should be_true
+        _report.running?.should be_true
       end
 
       Mel.start_and_stop

diff --git a/src/mel/progress/report.cr b/src/mel/progress/report.cr
@@ -19,14 +19,14 @@ struct Mel::Progress
     end
 
     def started? : Bool
-      pending? || moving?
+      pending? || running?
     end
 
     def pending? : Bool
       value == Progress::START
     end
 
-    def moving? : Bool
+    def running? : Bool
       Progress::START < value < Progress::END
     end