Skip to content

Commit

Permalink
Move all after_commit database operations to after_save
Browse files Browse the repository at this point in the history
  • Loading branch information
akadusei committed Jul 5, 2024
1 parent 458133d commit 15f78cd
Show file tree
Hide file tree
Showing 14 changed files with 15 additions and 14 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Changed
- Upgrade GitHub actions
- Move all `after_commit` database operations to `after_save`

## [1.1.2] - 2024-02-10

Expand Down
4 changes: 2 additions & 2 deletions src/shield/operations/delete_oauth_permission.cr
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ module Shield::DeleteOauthPermission # OauthClient::SaveOperation
macro included
needs user : User

after_commit delete_permission
after_commit delete_oauth_grants
after_save delete_permission
after_save delete_oauth_grants

private def delete_permission(oauth_client : Shield::OauthClient)
BearerLoginQuery.new
Expand Down
2 changes: 1 addition & 1 deletion src/shield/operations/delete_user_bearer_logins.cr
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module Shield::DeleteUserBearerLogins # User::SaveOperation
macro included
needs current_bearer_login : BearerLogin?

after_commit delete_bearer_logins
after_save delete_bearer_logins

private def delete_bearer_logins(user : Shield::User)
query = BearerLoginQuery.new.user_id(user.id)
Expand Down
2 changes: 1 addition & 1 deletion src/shield/operations/delete_user_email_confirmations.cr
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module Shield::DeleteUserEmailConfirmations # User::SaveOperation
macro included
after_commit delete_email_confirmations
after_save delete_email_confirmations

private def delete_email_confirmations(user : Shield::User)
EmailConfirmationQuery.new.user_id(user.id).delete
Expand Down
2 changes: 1 addition & 1 deletion src/shield/operations/delete_user_logins.cr
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module Shield::DeleteUserLogins # User::SaveOperation
macro included
needs current_login : Login?

after_commit delete_logins
after_save delete_logins

private def delete_logins(user : Shield::User)
query = LoginQuery.new.user_id(user.id)
Expand Down
2 changes: 1 addition & 1 deletion src/shield/operations/delete_user_oauth_clients.cr
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module Shield::DeleteUserOauthClients # User::SaveOperation
macro included
after_commit delete_oauth_clients
after_save delete_oauth_clients

private def delete_oauth_clients(user : Shield::User)
OauthClientQuery.new.user_id(user.id).delete
Expand Down
2 changes: 1 addition & 1 deletion src/shield/operations/delete_user_oauth_grants.cr
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module Shield::DeleteUserOauthGrants # User::SaveOperation
macro included
after_commit delete_oauth_grants
after_save delete_oauth_grants

private def delete_oauth_grants(user : Shield::User)
OauthGrantQuery.new.user_id(user.id).delete
Expand Down
2 changes: 1 addition & 1 deletion src/shield/operations/delete_user_password_resets.cr
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module Shield::DeleteUserPasswordResets # User::SaveOperation
macro included
after_commit delete_password_resets
after_save delete_password_resets

private def delete_password_resets(user : Shield::User)
PasswordResetQuery.new.user_id(user.id).delete
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module Shield::DeleteAccessTokensAfterDeactivateOauthClient
macro included
after_commit delete_access_tokens
after_save delete_access_tokens

private def revoke_access_tokens(oauth_client : Shield::OauthClient)
end
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module Shield::DeleteEmailConfirmationsAfterRegisterUser
macro included
after_commit delete_email_confirmations
after_save delete_email_confirmations

private def end_email_confirmations(user : Shield::User)
end
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module Shield::DeleteEmailConfirmationsAfterUpdateEmail
macro included
after_commit delete_email_confirmations
after_save delete_email_confirmations

private def end_email_confirmations(
email_confirmation : Shield::EmailConfirmation
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module Shield::DeleteGrantsAfterDeactivateOauthClient
macro included
after_commit delete_oauth_grants
after_save delete_oauth_grants

private def end_oauth_grants(oauth_client : Shield::OauthClient)
end
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module Shield::DeleteGrantsAfterRevokeOauthPermission
macro included
after_commit delete_oauth_grants
after_save delete_oauth_grants

private def revoke_oauth_grants(oauth_client : Shield::OauthClient)
end
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module Shield::DeletePasswordResetsAfterResetPassword
macro included
after_commit delete_password_resets
after_save delete_password_resets

private def end_password_resets(password_reset : Shield::PasswordReset)
end
Expand Down

0 comments on commit 15f78cd

Please sign in to comment.