Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outofmemory exception handled #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Outofmemory exception handled #2

wants to merge 7 commits into from

Conversation

vinitraj10
Copy link
Mannequin

@vinitraj10 vinitraj10 mannequin commented Aug 14, 2020

  1. Handled OutofMemory exception while doing a Bitmap.create
  2. Passing ReactNative context in Compression.java to show a toast message if an exception occurs

@vinitraj10 vinitraj10 mannequin requested a review from john1jan August 14, 2020 06:42
@vinitraj10 vinitraj10 mannequin added the bug Something isn't working label Aug 14, 2020
@john1jan
Copy link
Mannequin

john1jan mannequin commented Aug 26, 2020

You just remove this.reactContext ?

@vinitraj10
Copy link
Mannequin Author

vinitraj10 mannequin commented Aug 26, 2020

You just remove this.reactContext ?

Yeah removed the try catch handling where earlier using the toast to show message,but now have change the implementation of resize method in Compression.java file to efficiently fit BitMap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john1jan john1jan Awaiting requested review from john1jan

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinitraj10 @john1jan @vinitraj10