Merge pull request #463 from Groww-OSS/develop

[Icon Store] [SVG duplicate id issue fix]
Groww-OSS · Aug 9, 2024 · 1eb664b · 1eb664b
2 parents dadbe7a + e85bac7
commit 1eb664b
Show file tree

Hide file tree

Showing 9 changed files with 35 additions and 28 deletions.
diff --git a/packages/icon-store/.svgrrc.js b/packages/icon-store/.svgrrc.js
@@ -8,9 +8,16 @@ module.exports = {
         params: {
           overrides: {
             removeViewBox: false,
-          },
-        },
-      },
+            cleanupIds: {
+              // cleanUpIds minification seems to sometimes generate duplicate IDs.
+              // We disabled this so it now only uses the id that was in the SVG to begin with.
+              minify: false,
+              // Don't remove unused IDs, as sometimes they are applied later on via CSS.
+              remove: false
+            },
+          }
+        }
+      }
     ],
   },
   index: false,

diff --git a/packages/icon-store/package.json b/packages/icon-store/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@groww-tech/icon-store",
-  "version": "1.4.6",
+  "version": "1.4.7",
   "description": "Icon Library customized for use in Groww",
   "files": [
     "mi",

diff --git a/packages/icon-store/svgs/custom/bulb.svg b/packages/icon-store/svgs/custom/bulb.svg
diff --git a/packages/icon-store/svgs/custom/cash_stack_dark.svg b/packages/icon-store/svgs/custom/cash_stack_dark.svg
diff --git a/packages/icon-store/svgs/custom/cash_stack_light.svg b/packages/icon-store/svgs/custom/cash_stack_light.svg
diff --git a/packages/icon-store/svgs/custom/digilocker.svg b/packages/icon-store/svgs/custom/digilocker.svg