Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Just one datapoint in query #2

Open
AkashDeepSwiggy opened this issue Jul 28, 2023 · 0 comments
Open

Just one datapoint in query #2

AkashDeepSwiggy opened this issue Jul 28, 2023 · 0 comments

Comments

@AkashDeepSwiggy
Copy link

According to the paper, the query in each meta triplet, there are n data points:
T = < x(i), · · · , x(i+n−1) >, x(+), x(−)>

However, in the code, in the triplet_batch_generator function, I can see that the example/query samples just one datapoint:

        sid = rng.choice(len(inlier_ids), 1, p = positive_weights)
        examples[i] = inlier_ids[sid]

Have we taken the case n=1 here, or am I missing something?

If this was missed, would love to contribute to fixing this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AkashDeepSwiggy