Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two Opacity Fade Modifier corner cases. #300

Merged
merged 3 commits into from
Oct 15, 2021
Merged

Fix two Opacity Fade Modifier corner cases. #300

merged 3 commits into from
Oct 15, 2021

Conversation

Deledrius
Copy link
Member

Addresses two issues discussed in #203:

  • Fixes an irrelevant warning message being shown when an Opacity Fader is set to FadeOpacity.
  • Creates the necessary Coordinate Interface for an Opacity Fader set to FadeOpacity.

@Deledrius
Fix irrelevant fade distance warning.
19b4b8e
@Deledrius
Export CI for plFadeOpacityMods.
d06ac03 
plFadeOpacityMods require a Coordinate Interface to correctly calculate LOS.
@Deledrius @Hoikas
Simplify Opacity Fader CI condition.
c0a6d0e 
Co-authored-by: Adam Johnson <AdamJohnso@gmail.com>
@Hoikas Hoikas merged commit d2ead7a into H-uru:master Oct 15, 2021
@Deledrius Deledrius deleted the fade_fixes branch October 15, 2021 15:15
@Hoikas Hoikas mentioned this pull request Mar 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoikas Hoikas Hoikas approved these changes

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Deledrius @Hoikas