Use FindPython from CMake 3.12. #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
force-pushed
the
find_python
branch
5 times, most recently
from
188d3f5
to
56b360f
Compare
zrax
reviewed
Jun 15, 2020
|
This needs to be rebased after #199 is merged |
|
Per the CMake 3.27.0 release notes:
I should probably rebase this 😞 |
Hoikas
force-pushed
the
find_python
branch
2 times, most recently
from
71b2f3e
to
9d48bc0
Compare
Hoikas
force-pushed
the
find_python
branch
3 times, most recently
from
b48b258
to
9c9394c
Compare
|
This is ready to go for CMake 3.27 compatibility. |
zrax
reviewed
Sep 17, 2023
The `distutils` module will be tossed in Python 3.12, so compensate for that.
Hoikas
commented
Sep 17, 2023
| install(TARGETS PyHSPlasma | ||
| RUNTIME DESTINATION bin | ||
| LIBRARY DESTINATION lib | ||
| LIBRARY DESTINATION bin |
There was a problem hiding this comment.
CMake's FindPython3 (source of Python3_add_library) thinks Python extension modules are libraries. 🙄
zrax
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate the writing of a vcpkg port, this updates the PyHSPlasma CMake to use the FindPython module from CMake 3.12. The previously used module has since been deprecated. To manually specify artifacts from a specific python version, set the keys
Python_INCLUDE_DIRandPython_LIBRARY. Note the casing has changed fromPYTHON(deprecated) toPython.I think these changes were previously included in #166, but the ability to manually specify the artifacts did not land until CMake 3.16.