Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Really preserve ObjIDs. #280

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Really preserve ObjIDs. #280

merged 3 commits into from
Oct 19, 2023

Commits on Oct 19, 2023

  1. Expose preserveObjIDs to Python.

    @Hoikas
    Hoikas committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    0d948a2 View commit details
    Browse the repository at this point in the history

  2. Fix an issue whereby ObjIDs are not preserved. 

    Previously, when a uoid is read in from the stream, the ObjID from the
stream is discarded and reassigned to the value we already know. If the
key is not already known, then the next sequential ID is given. If we
want to preserve IDs, then we probably want to preserve *all* IDs, even
those mid-stream. This is most apparent when diffing PRPs. IDs of zero
are special values to the game client that mean "always look this up by
name." This situation exists in the wild, right now, on MOULa's
BahroCave_District_YeeshaCave.prp. When this file is read, libHSPlasma
assigns sequential IDs to the `plMipmap` references in the layers if the
Textures PRP is not already loaded. If the common PRP_as_Text.py is used
to diff the PRP, a comparison is made against a random/junk value,
resulting in a spurious looking change. See H-uru/moul-assets#244 for an
example of the confusion.
    @Hoikas
    Hoikas committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    c1797bf View commit details
    Browse the repository at this point in the history

  3. Apply suggestion from CR. 

    Co-authored-by: Joseph Davies <deledrius@gmail.com>
    @Hoikas @Deledrius
    Hoikas and Deledrius authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    b8b5e77 View commit details
    Browse the repository at this point in the history