Add checkbox to enable/disable DynamicCamMaps to the Options Menu. #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that we no longer need to round trip the localized strings through Python, improving performance and reducing code bloat in xOptionsMenu.py. As a drive by, I changed the monitor calibration instructions to scale with resolution, so they should be more legible on high resolution displays.
This allows the user to turn off DynamicCamMaps, which can be fairly expensive. This mirrors a similar option in Myst V.
Deledrius
approved these changes
Mar 3, 2024
|
As of #253, this checkbox causes the DCM in K'veer to turn on/off as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the options menu to add a checkbox for enabling/disabling DynamicCamMaps. This was possible in Myst V, so it was just a matter of updating the options menu GUI and the options menu script to support this option. I took the verbiage "Dynamic Reflections" from Myst V. Here is the updated graphics settings dialog:
In Myst V, it looks like:
I removed the subtext for the windowed mode checkbox for the mac client. The TransGaming mac client and its limitations are no longer relevant to us, and the windowed checkbox works fine on the current H'uru mac client.
As drive bys, I updated the localization files to include all of the strings used by the options menu and added references to those into max. This means that the manual localization of the dialog can be removed from xOptionsMenu.py. Some strings are in weird places, such as audio strings being in the game set - I just rolled with what was already there to reduce noisy deltas. Further, I fixed #247 by removing the EAX logo and resizing the audio settings dialog to remove the deadspace formerly occupied by the EAX logo. User facing references to "EAX" have been replaced with "EFX". The audio settings dialog looks like this now:
Note that this requires a corresponding update to xOptionsMenu.py, which is forthcoming.
NOTE: Due to H-uru/korman#407, using this checkbox with the K'veer PRPs currently in this repo seems to have no effect. This is by design in the engine. Once the cited issue is fixed and K'veer is re-exported, everything should work correctly.