Phpstan level 2 #245
Open
Phpstan level 2 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hallo @Art4, |
|
Prima, vielen Dank. Ich habe #244 freigegeben und prüfe noch, ob es mergen Conflicts gibt, die ich beheben muss. |
|
Merge Conflicts sind behoben. Dieser PR ist bereit für das Review. |
holema
approved these changes
Sep 24, 2024
Art4
commented
Oct 11, 2024
Comment on lines
132
to
+134
| try { | ||
| // FIXME: ResourceOwnerInterface cannot have method getEmail() | ||
| return $keycloakUser->getEmail(); | ||
| if ($keycloakUser instanceof User) { |
There was a problem hiding this comment.
@holema Ich bin mir nicht sicher, wie hier verfahren werden soll. Im Prinzip kann die ganze Methode reduziert werden:
private function getEmailForKeycloakUser(ResourceOwnerInterface $keycloakUser): string {
try {
return $keycloakUser->toArray()['preferred_username'];
} catch (Exception $e) {
return '';
}
}
There was a problem hiding this comment.
Die Idee ist, das versucht wird ob auf die email als Attribut zugegriffen werden kann.
prefered suername muss nicht unbedingt die email Adresse sein sondern kann auch ein username sein.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes all errors for PHPStan level 2. This is a follow-up of #244.
To teach PHPStan about Doctrine repositories, I've installed the phpstan-doctrine extension as dev dependency.
This PR fixes all reported 58 errors, including #242.