Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jsonToArray error on empty data read #237

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Fix jsonToArray error on empty data read #237

merged 2 commits into from
Aug 8, 2023

Conversation

mattjala
Copy link
Contributor

This lets clients read from an empty attribute without causing an internal server error.

Previously, a value in data_json being None caused errors when passed to np.array.

@mattjala
Fix jsonToArray error on empty data read
f97925d 
This lets clients read from an empty attribute without causing
an internal server error.
@mattjala mattjala added the bug label Jun 15, 2023
jreadey
jreadey reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this in array_util_test.py?

@jreadey jreadey merged commit 822fe76 into HDFGroup:master Aug 8, 2023
7 checks passed
@mattjala mattjala mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreadey jreadey jreadey approved these changes

Assignees

@jreadey jreadey

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjala @jreadey