Setup #250
Merged
Setup #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
reviewed
Aug 24, 2023
| @@ -241,16 +249,25 @@ def main(): | |||
| print(f"unsupported log_level: {log_level_cfg}, using INFO instead") | |||
| log_level = logging.INFO | |||
|
|
|||
| print("set logging to:", log_level) | |||
| print("set logging to::", log_level) | |||
mattjala
reviewed
Aug 24, 2023
README.md
Outdated
| 4. Run the test suite. In a separate terminal run: | ||
| - Set user_name: `$ export USER_NAME=$USER` | ||
| - Set user_password: `$ export USER_PASSWORD=$USER` | ||
| - Set admin name: `$ export ADMIN_USER=$USER` |
There was a problem hiding this comment.
ADMIN_USER -> ADMIN_USERNAME
|
The unix socket tests and docker tests will work with the new build. Besides the |
mattjala
previously approved these changes
Aug 24, 2023
kandersolar
reviewed
Oct 17, 2023
| else: | ||
| if not os.path.isdir(root_dir): | ||
| sys.exit(f"directory: {root_dir} not found") | ||
| bucket_path = os.path.join(root_dir, bucket_name) |
|
yes, no sure how the nargs got in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to make it more convenient to directly run hsds app.