Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listkeys #333

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Listkeys #333

merged 5 commits into from
Mar 29, 2024

Conversation

jreadey
Copy link
Member

@jreadey jreadey commented Mar 28, 2024

Break up list_keys in fileClient with some asyncio.sleep()'s so that other tasks have a chance to run (c.f. issue #332).
Also, reduce log verbosity.

@assaron
Copy link
Contributor

assaron commented Mar 29, 2024

@jreadey hope I'm not invading here, but did you mean the opposite condition here?

if len(files) % 1000:
As I understand, currently it sleeps after each file, except for 1000th, but I guess the idea was to sleep only each 1000th file.

@mattjala
Copy link
Contributor

I second @assaron's observation. Other than that, LGTM.

@jreadey
Copy link
Member Author

jreadey commented Mar 29, 2024

Yes, silly mistake!

@jreadey jreadey merged commit 712ff40 into master Mar 29, 2024
10 checks passed
@assaron
Copy link
Contributor

assaron commented Mar 29, 2024

Sorry, I didn't specify, but there is second place with that problem as well:

if len(files) % 1000:

@jreadey
Copy link
Member Author

jreadey commented Mar 29, 2024

I'm consistent at least...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants