Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set platform in docker-compose so it works on other platforms than amd64 #389

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

rho-novatron
Copy link
Contributor

@rho-novatron rho-novatron commented Aug 26, 2024

With this change, runall.sh works on e.g. macos with Apple Silicon.

@rho-novatron
Copy link
Contributor Author

The test fail is this:

’’’
Traceback (most recent call last):
File "D:\a\hsds\hsds\tests\integ\value_test.py", line 3809, in testShapeReinitialization3D
self.assertEqual(rsp.status_code, 201)
AssertionError: 409 != 201
’’’

I can’t really see how this change could provoke that test fail…

Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR .
The test fail is a known issue on the windows platform. Since the clock resolution on Windows is less compared with Linux/MacOS, tests the depend on listing attributes or links by creation order sometime fail.

@jreadey jreadey merged commit c342968 into HDFGroup:master Aug 26, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants